Skip to content

Add missing semicolon in http_client.rst #12567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add missing semicolon in http_client.rst #12567

wants to merge 1 commit into from

Conversation

XWB
Copy link
Contributor

@XWB XWB commented Oct 30, 2019

No description provided.

@javiereguiluz javiereguiluz added this to the 4.3 milestone Oct 30, 2019
javiereguiluz
javiereguiluz approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you!

Note to mergers: to be merged in 4.3.

@XWB XWB changed the base branch from master to 4.3 October 30, 2019 15:42
@XWB XWB changed the base branch from 4.3 to master October 30, 2019 15:42
@XWB XWB mentioned this pull request Oct 30, 2019
Merged
@XWB
Copy link
Contributor Author

XWB commented Oct 30, 2019

@javiereguiluz I'm now targeting the correct branch with a new PR: #12569

@XWB XWB closed this Oct 30, 2019
@XWB XWB deleted the http-client-doc-fix branch October 30, 2019 15:47
OskarStark added a commit that referenced this pull request Oct 30, 2019
@OskarStark
bug #12569 Add missing semicolon in http_client.rst (XWB)
21c334d 
This PR was merged into the 4.3 branch.

Discussion
----------

Add missing semicolon in http_client.rst

Replaces #12567

Commits
-------

5909b29 Add missing semicolon
@javiereguiluz
Copy link
Member

Thanks but for the next time, there's no need to do that. Symfony mergers use a proprietary tool that can change the branch while merging. It doesn't mean more work for mergers because the tool does everything automatically. Cheers.

@XWB
Copy link
Contributor Author

XWB commented Oct 30, 2019

I'll keep that in mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
HttpClient Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@XWB @javiereguiluz @carsonbot